moanos/Notfellchen
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove redundant serializer

Browse Source
This commit is contained in:
moanos [he/him]
2025-05-23 19:51:28 +02:00
parent 7a37377a09
commit 43c671018b
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/fellchensammlung/api/serializers.py
View File

@@ -38,13 +38,6 @@ class AnimalCreateSerializer(serializers.ModelSerializer):
fields = ["name", "date_of_birth", "description", "species", "sex", "adoption_notice"] fields = ["name", "date_of_birth", "description", "species", "sex", "adoption_notice"]
class RescueOrgSerializer(serializers.ModelSerializer):
class Meta:
model = RescueOrganization
fields = ["name", "location_string", "instagram", "facebook", "fediverse_profile", "email", "phone_number",
"website", "description", "external_object_identifier", "external_source_identifier"]
class AnimalGetSerializer(serializers.ModelSerializer): class AnimalGetSerializer(serializers.ModelSerializer):
class Meta: class Meta:
model = Animal model = Animal

10
src/fellchensammlung/api/views.py
View File

@@ -14,7 +14,7 @@ from .serializers import (
RescueOrganizationSerializer, RescueOrganizationSerializer,
AdoptionNoticeSerializer, AdoptionNoticeSerializer,
ImageCreateSerializer, ImageCreateSerializer,
SpeciesSerializer, RescueOrgSerializer, SpeciesSerializer, RescueOrganizationSerializer,
) )
from fellchensammlung.models import Animal, RescueOrganization, AdoptionNotice, Species, Image from fellchensammlung.models import Animal, RescueOrganization, AdoptionNotice, Species, Image
from drf_spectacular.utils import extend_schema from drf_spectacular.utils import extend_schema
@@ -203,14 +203,14 @@ class RescueOrganizationApiView(APIView):
@transaction.atomic @transaction.atomic
@extend_schema( @extend_schema(
request=RescueOrgSerializer, request=RescueOrganizationSerializer,
responses={201: 'Rescue organization created successfully!'} responses={201: 'Rescue organization created successfully!'}
) )
def post(self, request, *args, **kwargs): def post(self, request, *args, **kwargs):
""" """
Create or update a rescue organization. Create or update a rescue organization.
""" """
serializer = RescueOrgSerializer(data=request.data, context={"request": request}) serializer = RescueOrganizationSerializer(data=request.data, context={"request": request})
if serializer.is_valid(): if serializer.is_valid():
rescue_org = serializer.save() rescue_org = serializer.save()
# Add the location # Add the location
@@ -224,7 +224,7 @@ class RescueOrganizationApiView(APIView):
@transaction.atomic @transaction.atomic
@extend_schema( @extend_schema(
request=RescueOrgSerializer, request=RescueOrganizationSerializer,
responses={200: 'Rescue organization updated successfully!'} responses={200: 'Rescue organization updated successfully!'}
) )
def patch(self, request, *args, **kwargs): def patch(self, request, *args, **kwargs):
@@ -240,7 +240,7 @@ class RescueOrganizationApiView(APIView):
except RescueOrganization.DoesNotExist: except RescueOrganization.DoesNotExist:
return Response({"error": "Organization not found."}, status=status.HTTP_404_NOT_FOUND) return Response({"error": "Organization not found."}, status=status.HTTP_404_NOT_FOUND)
serializer = RescueOrgSerializer(organization, data=request.data, partial=True, context={"request": request}) serializer = RescueOrganizationSerializer(organization, data=request.data, partial=True, context={"request": request})
if serializer.is_valid(): if serializer.is_valid():
serializer.save() serializer.save()
return Response({"message": "Rescue organization updated successfully!"}, status=status.HTTP_200_OK) return Response({"message": "Rescue organization updated successfully!"}, status=status.HTTP_200_OK)